[PATCH 3/7] rtc: sa1100: use ioremap to map registers

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Feb 22 18:58:05 EST 2012


On Tue, Feb 21, 2012 at 05:04:52PM +0800, Haojian Zhuang wrote:
> diff --git a/arch/arm/mach-sa1100/generic.c b/arch/arm/mach-sa1100/generic.c
> index bb10ee2..04a62a3 100644
> --- a/arch/arm/mach-sa1100/generic.c
> +++ b/arch/arm/mach-sa1100/generic.c
> @@ -345,9 +345,29 @@ void sa11x0_register_irda(struct irda_platform_data *irda)
>  	sa11x0_register_device(&sa11x0ir_device, irda);
>  }
>  
> +static struct resource sa1100_rtc_resources[] = {
> +	{
> +		.start	= 0x90010000,
> +		.end	= 0x9001003f,
> +		.flags	= IORESOURCE_MEM,
> +	}, {
> +		.start  = IRQ_RTC1Hz,
> +		.end    = IRQ_RTC1Hz,
> +		.name	= "rtc 1Hz",
> +		.flags  = IORESOURCE_IRQ,
> +	}, {
> +		.start  = IRQ_RTCAlrm,
> +		.end    = IRQ_RTCAlrm,
> +		.name	= "rtc alarm",
> +		.flags  = IORESOURCE_IRQ,
> +	},
> +};

As I've converted all resources in this file to use the DEFINE_RES_foo()
macros, it would be a shame to have this initialization reintroduced.
Please use DEFINE_RES_foo() here.



More information about the linux-arm-kernel mailing list