[PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Feb 22 14:35:27 EST 2012


On Wed, Feb 22, 2012 at 10:50:29PM +0530, Jassi Brar wrote:
> > * Based on:
> > *       arch/arm/common/pl330.c, arch/arm/include/asm/hardware/pl330.h
> > *       Copyright (C) 2010 Samsung Electronics Co Ltd.
> >
> Doesn't make any sense because arch/arm/common/pl330.c
> and arch/arm/include/asm/hardware/pl330.h wouldn't exist anymore,

Rubbish.  It does make sense, because it's saying where the changes
came from.  That's done quite often when moving code around.

You could say that moving code from file A to file B and commenting
that it came from file A makes no sense because the code is no longer
in file A.  Well, that's definitely the case, but that doesn't mean
you don't credit where it came from in the first place.

I think you're making a mountain out of this mole hill.  There isn't
a problem here.  The above comments saying what happened are fine.



More information about the linux-arm-kernel mailing list