[PATCH 2/2] ARM: S3C24XX: Move the DMA base code to mach-s3c24xx

[Kukjin Kim]

On 02/23/12 02:21, Arnd Bergmann wrote:
> On Tuesday 21 February 2012, Heiko Stübner wrote:
>> Signed-off-by: Heiko Stuebner<heiko at sntech.de>
>> ---
>>   arch/arm/mach-s3c24xx/Kconfig  |   18 +
>>   arch/arm/mach-s3c24xx/Makefile |    1 +
>>   arch/arm/mach-s3c24xx/dma.c    | 1469 ++++++++++++++++++++++++++++++++++++++++
>>   arch/arm/plat-s3c24xx/Kconfig  |   16 -
>>   arch/arm/plat-s3c24xx/Makefile |    1 -
>>   arch/arm/plat-s3c24xx/dma.c    | 1469 ----------------------------------------
>>   6 files changed, 1488 insertions(+), 1486 deletions(-)
>>   create mode 100644 arch/arm/mach-s3c24xx/dma.c
>>   delete mode 100644 arch/arm/plat-s3c24xx/dma.c
>>
>
> Wouldn't it be more appropriate to move this driver to
> drivers/dma/s3c24xx-dma.c instead?
>
Basically I agree, it is just specific dma only for s3c24xx though.

I think, for that, we need to update its driver when moving.

> Even if it doesn't (yet) use the dmaengine API, I think it's
> valuable to keep drivers with the same purpose together. We have
> had similar discussions in other subsystems and ended up moving
> the drivers into one directory first, followed by a conversion
> to a common API (if someone could be motivated to do that work).
>
Yes, and we need to move s3c24xx cpufreq to drivers/cpufreq and it will 
be done soon.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.