[PATCH v2 19/19] ARM: at91/board-dt: move at91_initialize() to init_irq()

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Feb 22 04:48:27 EST 2012

On Wed, Feb 22, 2012 at 10:39:45AM +0100, Nicolas Ferre wrote:
> From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> Remove the need for at91_initialize() to be called at init_early().
> We move it to init_irq() function as we still need it before the
> timer initialization.
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> Acked-by: Nicolas Ferre <nicolas.ferre at atmel.com>

NAK.  Keep the callback methods pure.  The whole point of the init_early
is so that soc people don't end up polluting things like the IRQ
initialization and timer initialization with stuff like this.

So this is a backwards step.

More information about the linux-arm-kernel mailing list