[PATCH v2 6/6] mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply
Rajendra Nayak
rnayak at ti.com
Tue Feb 21 07:41:52 EST 2012
On Tuesday 21 February 2012 05:50 PM, Russell King - ARM Linux wrote:
> On Tue, Feb 21, 2012 at 05:43:54PM +0530, S, Venkatraman wrote:
>> On Tue, Feb 21, 2012 at 3:33 PM, Rajendra Nayak<rnayak at ti.com> wrote:
>>> @@ -324,8 +302,8 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host
>>> *host)
>>> mmc_slot(host).ocr_mask = ocr_value;
>>> } else {
>>> if (!(mmc_slot(host).ocr_mask& ocr_value)) {
>>> - pr_err("MMC%d ocrmask %x is not
>>> supported\n",
>>> - host->id,
>>> mmc_slot(host).ocr_mask);
>>> + pr_err("MMC ocrmask %x is not
>>> supported\n",
>>> + mmc_slot(host).ocr_mask);
>
> You're dropping the MMC number from these error messages. It would be
> much better to fix them instead. Use dev_info(mmc_dev(host->mmc), "blah"
> rather than pr_err().
Thanks for catching this. There are a few other instance of pr_* usage
within the driver. I will post a patch to fix all of them.
>
> Drivers should not be using pr_* unless they really do not have a struct
> device.
More information about the linux-arm-kernel
mailing list