[PATCH] ARM: ptrace: fix ptrace_read_user for !CONFIG_MMU platforms

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Feb 20 14:46:34 EST 2012


On Mon, Feb 20, 2012 at 06:37:09PM +0000, Will Deacon wrote:
> Commit 68b7f715 ("nommu: ptrace support") added definitions for
> PT_TEXT_ADDR and friends, as well as adding ptrace support for reading
> from these magic offsets.
> 
> Unfortunately, this has probably never worked, since ptrace_read_user
> predicates reading on off < sizeof(struct user), returning -EOI
> otherwise.
> 
> This patch moves the offset size check until after we have tried to
> match it against either a magic value or an offset into pt_regs.

Does this actually get used?  The fact that it's been broken from day one
and no one's raised the issue in 2.5 years suggests that it's dead code.



More information about the linux-arm-kernel mailing list