[PATCH] ARM: need to include asm/system.h in asm/processor.h
Rob Herring
robherring2 at gmail.com
Wed Feb 15 15:06:41 EST 2012
On 02/15/2012 01:59 PM, David Brown wrote:
> On Wed, Feb 15, 2012 at 11:20:10AM -0800, Olof Johansson wrote:
>> For files that include asm/processor.h but not asm/system.h:
>>
>> arch/arm/mach-msm/include/mach/uncompress.h: In function 'putc':
>> arch/arm/mach-msm/include/mach/uncompress.h:48:3: error: implicit declaration of function 'smp_mb' [-Werror=implicit-function-declaration]
>>
>> In this case, smp_mb() is from the cpu_relax() call in the msm putc().
>>
>> It likely went uncaught when the uncompress.h change went in since the
>> defconfig didn't enable that code path, but later changes (e76f4750f4:
>> ARM: debug: arrange Kconfig options more logically) resulted in the
>> option being on for msm_defconfig and thus exposed it.
>>
>> Signed-off-by: Olof Johansson <olof at lixom.net>
>
> BTW, Rob Herring has this same patch in his io.h cleanup patches, so
> it's probably best to coordinate with him.
I'd just assumed that I had broken things by implicitly dropping a lot
of includes when removing mach/io.h. Go ahead and apply yours and I'll
drop mine.
Rob
> Author: Rob Herring <rob.herring at calxeda.com>
> Date: Mon Feb 13 15:43:15 2012 -0600
>
> ARM: add explicit include of system.h to processor.h
>
> cpu_relax in processor.h needs smp_mb which is defined in
> system.h.
>
> Signed-off-by: Rob Herring <rob.herring at calxeda.com>
>
> David
>
More information about the linux-arm-kernel
mailing list