[PATCH] ARM: ptrace: Include linux/audit.h to fix build errors

Nathaniel Husted nhusted at gmail.com
Wed Feb 15 11:14:36 EST 2012


The code in place regarding the endian-ness was put into place long
before my patch and I've no clue the original reasoning behind it.
Thus I'd defer the answer to Eric or other powers that be.

Cheers,
Nathaniel

On Wed, Feb 15, 2012 at 11:10 AM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Wed, Feb 15, 2012 at 10:10:58AM -0500, Eric Paris wrote:
>> On Wed, 2012-02-15 at 10:18 +0000, Russell King - ARM Linux wrote:
>>
>> > So, this gives us two options: either we revert the damned thing and start
>> > over with it (and hopefully audit folk will start co-operating with ARM
>> > folk) or we try to fix up their mess (and potentially they learn they can
>> > dump crap on us.)
>>
>> It must be a conspiracy to screw with the ARM people!  Your jobs were
>> obviously too easy to begin with.  Rahrrrrr!  Down with ARM!
>>
>> No seriously.  I am the audit folks.  You got us all right here in this
>> one e-mail.  You're right, I should have paid more attention to who was
>> in the cc list.  If you want to rewrite it, please feel free!  If you
>> want to push fixes yourself, please feel free!  If you want me to push
>> fixes, please just let me know what is broken and I'll do my best.
>>
>> Sorry.  I just got the patch and was contacted by a number of people off
>> list asking when it was going to go in because they wanted it for their
>> project.  I obviously should have known who the ARM maintainers that
>> would have looked at a patch for the audit system was and should have
>> made sure they commented.  Sorry!  I'll be sure to hit the ARM list if
>> another patch goes by....
>
> And... what about this endian-ness issue?
>
> Frustrated.
>
> I've tried discussing that issue with Nathaniel and haven't got anywhere
> with it (other than, seemingly, it's above his pay grade to know the
> answer.)
>
> Right, I've committed a revert of it to my tree.  When there's more
> interest in the feature, it can be revisited with proper review and
> proper testing of it.



More information about the linux-arm-kernel mailing list