[PATCH 00/15] mach/io.h cleanup and removal

Tony Lindgren tony at atomide.com
Tue Feb 14 12:24:23 EST 2012


* Rob Herring <robherring2 at gmail.com> [120213 18:49]:
> On 02/13/2012 05:41 PM, Tony Lindgren wrote:
> > * Rob Herring <robherring2 at gmail.com> [120213 13:12]:
> >>  arch/arm/mach-at91/include/mach/at91_io.h         |   44 +++++++++++++++++
> >>  arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h |    2 +
> >>  arch/arm/mach-at91/include/mach/at91sam9_sdramc.h |    2 +
> > ...
> >>  arch/arm/mach-msm/include/mach/msm_iomap-7x00.h   |    6 ++
> >>  arch/arm/mach-msm/include/mach/msm_iomap-7x30.h   |    4 ++
> >>  arch/arm/mach-msm/include/mach/msm_iomap-8960.h   |    4 ++
> >>  arch/arm/mach-msm/include/mach/msm_iomap-8x50.h   |    4 ++
> >>  arch/arm/mach-msm/include/mach/msm_iomap-8x60.h   |    4 ++
> > ...
> > 
> > Considering the naming above..
> > 
> >>  arch/arm/mach-tegra/include/mach/iomap.h          |   48 ++++++++++++++++++
> > 
> > ..should this be called tegra-iomap.h instead?
> 
> Probably, but it's not a new header. Fixing include paths or names is a
> separate problem when we start having multiple mach include directories.
> Perhaps we can get them removed altogether before we have to start
> renaming. Much of it is device addresses that will go in dts files.

Yes should be just the legacy drivers needing this for most part,
so that's currently most of omap1 drivers for us.

Anyways I'm using plat/omap-iomap.h for the name, so if somebody
has better ideas for naming to avoid further search and replace
later on, let me know.

I guess in the long run we could have

#include <mach-omap1/iomap.h>

instead of

#include <plat/omap-iomap.h>

as the plat can't be used for multi-subarch builds.

Regards,

Tony



More information about the linux-arm-kernel mailing list