[PATCH 2/2] ARM: OMAP4: Move the barrier memboclk_steal() as part of reserve callback

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Feb 14 06:13:05 EST 2012


On Fri, Feb 10, 2012 at 11:19:26AM -0800, Tony Lindgren wrote:
> * Santosh Shilimkar <santosh.shilimkar at ti.com> [120202 05:33]:
> > arm_memblock_steal() is not suppose to be used outside ->reserve callback.
> > OMAP barrier errata code was using it outside reserve callback and hence
> > it was broken.
> > 
> > Move the allocation as part of ->reserve callback to fix the it.
> 
> Please update this to mention again commit that changed things
> around for arm_memblock_steal() so it's clear why this is needed
> as a fix.

It's more the case that this whole errata fix was broken right from the
start, and the change to arm_memblock_steal() just enforced correct usage
of the APIs.

So, really the arm_memblock_steal() change has nothing to do with this.



More information about the linux-arm-kernel mailing list