[PATCH 1/2] ARM: OMAP: Get rid of reset for system timer

Rajendra Nayak rnayak at ti.com
Tue Feb 14 00:14:56 EST 2012


On Saturday 11 February 2012 12:48 AM, Tony Lindgren wrote:
> * Santosh Shilimkar<santosh.shilimkar at ti.com>  [120202 05:33]:
>> >  From: Rajendra Nayak<rnayak at ti.com>
>> >
>> >  hwmod setup already does a reset and sets the OCP sysconfig
>> >  registers appropriately. Avoid doing a reset again and overriding
>> >  the OCP sysconfig settings in the system timer init code.
 >
> If we want this queued as a fix, it should also describe what
> actually breaks? Timer? PM?

It only fixes the redundant reset and overriding the smartidle-wakeup
OCP setting (done by hwmod) with the smartidle in the driver.
Doing this doesn't really break anything as yet in mainline, but will
cause timer wakeup issues once OFF mode is in place for OMAP4. On OMAP5
however this was causing more issues as the softreset bit position is
different than on OMAP2/3/4.
So it should be ok to queue this in for 3.4 considering neither OMAP4
OFF, not OMAP5 support is in mainline yet.





More information about the linux-arm-kernel mailing list