[PATCH 13/15] ARM: make mach/io.h include optional
robherring2 at gmail.com
Mon Feb 13 17:55:45 EST 2012
On 02/13/2012 04:36 PM, Russell King - ARM Linux wrote:
> On Mon, Feb 13, 2012 at 03:43:26PM -0600, Rob Herring wrote:
>> From: Rob Herring <rob.herring at calxeda.com>
>> Add a kconfig option NEED_MACH_IO_H to conditionally include mach/io.h.
>> Basing this on CONFIG_PCI and CONFIG_ISA doesn't quite work. Most ISA
>> platforms don't need mach/io.h, but ebsa110 does.
> This is architecturally wrong. If you have ISA, and your __io() macro
> is essentially a 1:1 translation, you're asking for ISA drivers to
> scribble on whatever is at virtual address 0-64K. Too bad if that
> happens to be where your CPU vectors are stored, you'll lose control
> of the CPU in that case.
> In other words, if you have PCI or ISA and your __io() macro is a 1:1
> translation, you _need_ an io.h to define a proper offset for this.
> So, I think this patch series moves things in the wrong direction.
I think a lot of platforms are already broken in this way. The platforms
which actually do the right thing are unchanged and still have an io.h.
The remaining platforms only care about building ISA drivers, but not
actually using that code path.
Moving to a fixed IO virtual address range is the next step, but is
really an independent problem.
More information about the linux-arm-kernel