[PATCH 1/1] gpio: drop CONFIG_OF_GPIO in the definition of the struct gpio_chip
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Mon Feb 13 05:37:26 EST 2012
On 11:18 Mon 13 Feb , Nicolas Ferre wrote:
> On 02/13/2012 10:23 AM, Jean-Christophe PLAGNIOL-VILLARD :
> > this will allow to avoid the ifdef CONFIG_OF_GPIO in gpio drivers
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > Cc: Arnd Bergmann <arnd at arndb.de>
> > Cc: Nicolas Ferre <nicolas.ferre at atmel.com>
>
> Added devicetree-discuss ml.
>
> > ---
> > include/asm-generic/gpio.h | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
> > index 1ff4e22..c08b758 100644
> > --- a/include/asm-generic/gpio.h
> > +++ b/include/asm-generic/gpio.h
> > @@ -122,7 +122,6 @@ struct gpio_chip {
> > unsigned can_sleep:1;
> > unsigned exported:1;
> >
> > -#if defined(CONFIG_OF_GPIO)
> > /*
> > * If CONFIG_OF is enabled, then all GPIO controllers described in the
>
> Maybe you will need to rework this comment.
>
> > * device tree automatically may have an OF translation
> > @@ -131,7 +130,6 @@ struct gpio_chip {
> > int of_gpio_n_cells;
> > int (*of_xlate)(struct gpio_chip *gc,
> > const struct of_phandle_args *gpiospec, u32 *flags);
> > -#endif
>
> I do not know if we can remove the ifdef completely of just move of_node
> out of it.
basicaly ifdef on a struct is so so
so yes
Best Regards,
J.
More information about the linux-arm-kernel
mailing list