[PATCH 15/16] ARM: omap: resolve nebulous 'Error setting wl12xx data'
Tony Lindgren
tony at atomide.com
Wed Feb 8 13:56:50 EST 2012
* Russell King - ARM Linux <linux at arm.linux.org.uk> [120208 08:09]:
> It's useful to print the error code when a called function fails so a
> diagnosis of why it failed is possible. In this case, it fails because
> we try to register some data for the wl12xx driver, but as the driver
> is not configured, a stub function is used which simply returns -ENOSYS.
>
> Let's do the simple thing for -rc and print the error code.
>
> Also, the return code from platform_register_device() at each of these
> sites was not being checked. Add some checking, and again print the
> error code.
>
> This should be fixed properly for the next merge window so we don't
> issue error messages merely because a driver is not configured.
>
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
Looks right to me for -rc. Yes let's plan on fixing this for v3.4.
Acked-by: Tony Lindgren <tony at atomide.com>
More information about the linux-arm-kernel
mailing list