[PATCH 2/3] ARM: make disable_fiq macro optional

Nicolas Pitre nico at fluxnic.net
Tue Feb 7 00:24:15 EST 2012


On Mon, 6 Feb 2012, Rob Herring wrote:

> Nicolas,
> 
> On 02/06/2012 04:34 PM, Nicolas Pitre wrote:
> > On Mon, 6 Feb 2012, Rob Herring wrote:
> > 
> >> From: Rob Herring <rob.herring at calxeda.com>
> >>
> >> Only rpc uses disable_fiq, so make its use conditional on ARCH_RPC.
> >>
> >> With this, entry-macro.S is no longer needed for platforms that
> >> select MULTI_IRQ_HANDLER and the include of it can be conditional.
> > 
> > Using set_fiq_handler() in the rpc boot code we could get rid of 
> > disable_fiq entirely.
> > 
> 
> That's already being done here:
> arch/arm/mach-rpc/dma.c:290:    set_fiq_handler(fiqhandler_start,
> fiqhandler_length);
> 
> Can the macro just be deleted? Or a default handler needs to be setup
> earlier?

That's the handler installed by the RPC DMA code.  Another one is needed 
by default for when that code is not active.


Nicolas



More information about the linux-arm-kernel mailing list