[PATCH 1/4] i2c/gpio-i2c add: add DT support

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Feb 6 11:09:07 EST 2012


On Sun, Feb 05, 2012 at 11:38:53AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:

> +	- udelay: half clock cycle time in us (may depend on each platform)

> +	udelay = <2>;		/* ~100 kHz */

Why not specify this in kHz and do the conversion in the driver?  It
seems a more intuitive thing to be specifying.  I appreciate that the
platform data used udelay but it seems an entirely unintuitive thing
from a user point of view even if it's what the implementation wants.



More information about the linux-arm-kernel mailing list