[PATCH 1/5] USB: sa1111: sparse and checkpatch cleanups

Alan Stern stern at rowland.harvard.edu
Fri Feb 3 15:59:50 EST 2012


On Fri, 3 Feb 2012, Greg KH wrote:

> > There was one question mark I had over a patch - that was the addition
> > of the .reset method in the hc_driver for sa1111 stuff.  This seems to
> > only get called once during initial driver bring-up.  Comments I found
> > in the code suggest that it was used more often in the past.  Is that
> > something that's going away?
> 
> I don't think so, but Alan (on linux-usb@) would be the best to answer
> that one.

The "reset" method is not named very well; it really should be called
"initialize".  At any rate, you're right -- it gets called exactly once
during the lifetime of the HC, and no, that's not going to change.

Alan Stern




More information about the linux-arm-kernel mailing list