[PATCH 1/2] ARM: OMAP: Get rid of reset for system timer

Kevin Hilman khilman at ti.com
Fri Feb 3 12:54:07 EST 2012


"Shilimkar, Santosh" <santosh.shilimkar at ti.com> writes:

> On Fri, Feb 3, 2012 at 12:10 AM, Kevin Hilman <khilman at ti.com> wrote:
>> Santosh Shilimkar <santosh.shilimkar at ti.com> writes:
>>
>>> From: Rajendra Nayak <rnayak at ti.com>
>>>
>>> hwmod setup already does a reset and sets the OCP sysconfig
>>> registers appropriately. Avoid doing a reset again and overriding
>>> the OCP sysconfig settings in the system timer init code.
>>
>> That is true for OMAP4, but have you verified if this is indeed a
>> duplicate reset on  OMAP2/3?
>>
> Yes. It is duplicate for OMAP2 and OMAP3 devices as well.
> Actually this should have been fixed when the driver was
> hwmod converted but some how got missed. We noticed
> an issue on OMAP5, when timer interrupts stopped firing when
> always on clock domain was allowed to idle. This was because
> this reset was clearing the correctly set sysc value by hwmod.
>
> The patch is also tested on ZOOM3 ( OMAP3630)
> and OMAP2430SDP.

Great, thanks for testing on OMAP2/3.

Kevin



More information about the linux-arm-kernel mailing list