[PATCH v2 6/9] ARM: mx31ads: add audmux device

[Shawn Guo]

On Thu, Feb 02, 2012 at 05:24:28PM +0800, Richard Zhao wrote:
> On Thu, Feb 02, 2012 at 05:11:34PM +0800, Shawn Guo wrote:
> > On Thu, Feb 02, 2012 at 04:55:23PM +0800, Shawn Guo wrote:
> > > On Thu, Feb 02, 2012 at 10:12:05AM +0800, Richard Zhao wrote:
> > > > Signed-off-by: Richard Zhao <richard.zhao at linaro.org>
> > > > ---
> > > >  arch/arm/mach-imx/mach-mx31ads.c      |   10 ++++++++++
> > > >  arch/arm/plat-mxc/include/mach/mx31.h |    1 +
> > > >  2 files changed, 11 insertions(+), 0 deletions(-)
> > > > 
> > > Hmm, let's see who are actually using mxc_audmux_v2_configure_port().
> > > 
> > > $ git grep -n mxc_audmux_v2_configure_port arch/arm/
> > > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:246:     mxc_audmux_v2_configure_port(0,
> > > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:254:     mxc_audmux_v2_configure_port(4,
> > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c:257:     mxc_audmux_v2_configure_port(0,
> > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c:265:     mxc_audmux_v2_configure_port(3,
> > > arch/arm/mach-imx/mach-pcm043.c:365:    mxc_audmux_v2_configure_port(3,
> > > arch/arm/mach-imx/mach-pcm043.c:371:    mxc_audmux_v2_configure_port(0,
> I didn't grep arch/arm. where is pc043 asoc machine file?

It seems to be sound/soc/imx/phycore-ac97.c.

> > > 
> > As we are moving audmux into sound/soc/imx, it makes less sense to
> > still keep these calls in board files.
> It don't corrupt git bisect. We don't have to include it in this patch.

It's logically part of this series.

> >  Instead, I prefer to call it
> > from machine driver like what wm1133-ev1 does below.
> Maybe pass the info as asoc machine driver pdata.

Sounds good.

> >  Or we can simply
> > make the it a audmux-self call with 3 parameters it needs retrieved
> > from platform_data or device tree, so that machine driver does not
> > even bother with the call.  Makes sense?
> audux configuration may change after initial set. For example, it may use
> one configuration for audio playback, but use another when you connect a
> BT audio device.

Right.  I forgot this point.

-- 
Regards,
Shawn