[V4 3/4] power_supply: Enable battery-charger for 88pm860x

jett zhou jett.zhou at gmail.com
Thu Aug 23 05:06:22 EDT 2012


Hi Anton
    Thanks for helping me to amend these patch.
    I got many good suggestions and learn a lot in this process:)
    BTW, you mean you will help to amend that several minor warning with
battery tree?
    If there is something wrong, I can correct it.

Thanks



2012/8/23 Anton Vorontsov <anton.vorontsov at linaro.org>

> On Wed, Aug 22, 2012 at 08:48:15PM -0700, Anton Vorontsov wrote:
> [....]
> > drivers/mfd/88pm860x-core.c:803:53: warning: incorrect type in
> assignment (different base types)
> > drivers/mfd/88pm860x-core.c:803:53:    expected struct charger_regulator
> *charger_regulators
> > drivers/mfd/88pm860x-core.c:803:53:    got struct regulator_bulk_data
> static [toplevel] *
> >
> > They are minor, except for the last one. You seemed to use
> > 'regulator_bulk_data' struct (just as charger manager documentation
> > wrongly tells you, yup), but in real it should have been
> > 'struct charger_regulator'. The only reason that it worked is
> > because both 'supply' and 'regulator_name' struct members are the
> > first in these structs. :-)
>
> Oh, actually, I see that this is a result of extcon rework, so not
> your fault at all.
>
> Anton.
>



-- 

----------------------------------
Best Regards
Jett Zhou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120823/47533a24/attachment-0001.html>


More information about the linux-arm-kernel mailing list