Without MACH_ option Early printk (DEBUG_LL)

Hiremath, Vaibhav hvaibhav at ti.com
Fri Aug 31 13:23:12 EDT 2012


On Fri, Aug 31, 2012 at 22:43:36, Russell King - ARM Linux wrote:
> On Fri, Aug 31, 2012 at 08:24:51PM +0530, Vaibhav Hiremath wrote:
> > Hi Russell & Tony,
> > 
> > AM335X EVM (based on AM33XX device) only supports DT boot mode and
> > doesn't have CONFIG_MACH_AM335XEVM option defined. Some time back during
> > baseport submission we had aligned that, we won't create separate EVM
> > options, killing the board file all-together.
> > 
> > Having said that, the early printk option (DEBUG_LL) is broken, the
> > auto-generated file "./include/generated/mach-types.h" still refers to
> > CONFIG_MACH_AM335XEVM option,
> > 
> > #ifdef CONFIG_MACH_AM335XEVM
> > # ifdef machine_arch_type
> > #  undef machine_arch_type
> > #  define machine_arch_type     __machine_arch_type
> > # else
> > #  define machine_arch_type     MACH_TYPE_AM335XEVM
> > # endif
> > # define machine_is_am335xevm() (machine_arch_type == MACH_TYPE_AM335XEVM)
> > #else
> > # define machine_is_am335xevm() (0)
> > #endif
> 
> machine types are entirely meaningless for DT based systems.
> 
> > Can you comment on this? Based on that I will submit the patch.
> 
> Pointless.  You can't use machine_is_am335xevm() when you're using DT.
> 

They how do you recommend to resolve early prink issue (required during 
decompression)?

Thanks,
Vaibhav




More information about the linux-arm-kernel mailing list