[PATCH 05/10] ARM: at91: explicitly include mach/gpio.h

[Russell King - ARM Linux]

On Thu, Aug 30, 2012 at 07:14:46PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:31 Wed 29 Aug     , Rob Herring wrote:
> > From: Rob Herring <rob.herring at calxeda.com>
> > 
> > In preparation to remove implicit inclusion of mach/gpio.h, add explict
> > include of mach/gpio.h.
> I'm going to drop it for 3.7 too
> 
> the attached patch will do the same but in a more simpler way

I wonder whether you read your patches before you send them... it's
sometimes quite a good idea to review your own patches. :)

> diff --git a/arch/arm/mach-at91/gpio.c b/arch/arm/mach-at91/gpio.c
> index c5d7e1e..6803baa 100644
> --- a/arch/arm/mach-at91/gpio.c
> +++ b/arch/arm/mach-at91/gpio.c
> @@ -30,6 +30,7 @@
>  #include <mach/at91_pio.h>
>  
>  #include "generic.h"
> +#include "generic.h"

That's fairly obviously wrong.