[PATCH] usb: chipidea: cleanup dma_pool if udc_start() fails

Richard Zhao richard.zhao at freescale.com
Tue Aug 28 07:42:36 EDT 2012


On Tue, Aug 28, 2012 at 12:52:19PM +0200, Marc Kleine-Budde wrote:
> On 08/28/2012 12:46 PM, Richard Zhao wrote:
> > On Tue, Aug 28, 2012 at 12:31:25PM +0200, Marc Kleine-Budde wrote:
> >> If udc_start() fails the qh_pool dma-pool cannot be closed because
> >> it's still in use. This patch factors out the dma_pool_free() loop
> >> into destroy_eps() and calls it in the error path of udc_start(),
> >> too.
> >>
> >> Cc: Richard Zhao <richard.zhao at freescale.com>
> >> Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
> >> ---
> >> Hello,
> >>
> >> Richard, can you please include this patch in your stack. IIRC I think it once
> >> was, but now it's not anymore.
> > Sorry for that. I just push it to my topics/usb-driver branch.
> > Of course, it's better, if Alex can give a ACK and Greg could pick up.
> 
> I'm not sure, if this [1] is the latest thread on this patch, but Greg
> asked to queue this patch into your tree.
It does not depends on my tree any more. It can be applied directly on
Greg's tree.

Thanks
Richard
> 
> Marc
> 
> [1] http://comments.gmane.org/gmane.linux.usb.general/66440
> -- 
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
> 






More information about the linux-arm-kernel mailing list