[PATCH v3 17/23] serial: omap: unlock the port lock
Felipe Balbi
balbi at ti.com
Thu Aug 23 06:32:57 EDT 2012
From: Ruchika Kharwar <ruchika at ti.com>
This patch unlocks the port lock before calling a serial_core API
and re-acquires the port lock after calling it.
This patch fixes a system freeze issue seen when the serial_core
API uart_write_wakeup() eventually attempts to acquire the port lock
already acquired by omap serial interrupt handler.
Tested-by: Shubhrajyoti D <shubhrajyoti at ti.com>
Signed-off-by: Ruchika Kharwar <ruchika at ti.com>
Signed-off-by: Pavan Savoy <pavan_savoy at ti.com>
Signed-off-by: Vijay Badawadagi <bvijay at ti.com>
Signed-off-by: Felipe Balbi <balbi at ti.com>
---
drivers/tty/serial/omap-serial.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index ba22247..e871635 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -223,8 +223,11 @@ static void transmit_chars(struct uart_omap_port *up, unsigned int lsr)
break;
} while (--count > 0);
- if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
+ if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) {
+ spin_unlock(&up->port.lock);
uart_write_wakeup(&up->port);
+ spin_lock(&up->port.lock);
+ }
if (uart_circ_empty(xmit))
serial_omap_stop_tx(&up->port);
--
1.7.12.rc3
More information about the linux-arm-kernel
mailing list