[PATCH] mxs/spi: Fix misuse of init_completion

[Chris Ball]

Hi,

On Wed, Aug 22 2012, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Chris Ball <cjb at laptop.org>
> Cc: Shawn Guo <shawn.guo at linaro.org>
> Cc: Mark Brown <broonie at opensource.wolfsonmicro.com>
> Cc: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  drivers/spi/spi-mxs.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
> index 331f600..c965cc6 100644
> --- a/drivers/spi/spi-mxs.c
> +++ b/drivers/spi/spi-mxs.c
> @@ -230,7 +230,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi, int cs,
>  		return -EINVAL;
>  	}
>  
> -	init_completion(&spi->c);
> +	INIT_COMPLETION(spi->c);
>  
>  	if (*first)
>  		pio |= BM_SSP_CTRL0_LOCK_CS;
> @@ -560,6 +560,8 @@ static int __devinit mxs_spi_probe(struct platform_device *pdev)
>  	ssp->devid = devid;
>  	ssp->dma_channel = dma_channel;
>  
> +	init_completion(&spi->c);
> +
>  	ret = devm_request_irq(&pdev->dev, irq_err, mxs_ssp_irq_handler, 0,
>  			       DRIVER_NAME, ssp);
>  	if (ret)

Please be more specific with commit messages -- is there an observed
symptom that this fixes?  Does the patch need to go to stable@, too?

Thanks,

- Chris.
-- 
Chris Ball   <cjb at laptop.org>   <http://printf.net/>
One Laptop Per Child