[PATCH 2/2] ARM: EXYNOS: Enable PINCTRL config option for Exynos4 device tree enabled platform

[Thomas Abraham]

On 21 August 2012 18:01, Linus Walleij <linus.walleij at linaro.org> wrote:
> On Wed, Aug 15, 2012 at 10:10 PM, Thomas Abraham
> <thomas.abraham at linaro.org> wrote:
>
>> This enables support for Samsung and Exynos4 pinctrl driver for device
>> tree enabled Exynos4 platforms.
>>
>> Cc: Kukjin Kim <kgene.kim at samsung.com>
>> Signed-off-by: Thomas Abraham <thomas.abraham at linaro.org>
>> ---
>>  arch/arm/mach-exynos/Kconfig |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
>> index b5b4c8c..ad96c59 100644
>> --- a/arch/arm/mach-exynos/Kconfig
>> +++ b/arch/arm/mach-exynos/Kconfig
>> @@ -405,6 +405,7 @@ config MACH_EXYNOS4_DT
>>         select USE_OF
>>         select ARM_AMBA
>>         select HAVE_SAMSUNG_KEYPAD if INPUT_KEYBOARD
>> +       select PINCTRL
>
> I don't think this works, since PINCTRL_SAMSUNG is not default "y"
> (nor should it be).

I think I got this wrong. PINCTRL_SAMSUNG depends of OF, which is not
correct. The correct way would be select PINCTRL_SAMSUNG from
PINCTRL_EXYNOS4. I will fix this.

>
> For the platforms I converted I had to select both the subsystem and
> the indivudual driver, as is already done for some GPIO controllers
> for example:
>
> select PINCTRL
> select PINCTRL_SAMSUNG
>
> Yours,
> Linus Walleij

Thanks,
Thomas.