[rtc-linux] [PATCH v3] rtc: snvs: add Freescale rtc-snvs driver

[Lothar Waßmann]

Hi,

Shawn Guo writes:
> On Thu, Aug 16, 2012 at 10:08:04AM +0200, Lothar Waßmann wrote:
> > Why not read the register once more in case of a timeout, which
> > would guarantee to have a current view of the register contents no
> > matter how long the process may have been descheduled before:
> > 
> > [...]
> > static int snvs_rtc_enable_done(int enable, void __iomem *addr)
> > {
> > 	u32 lpcr = readl(addr + SNVS_LPCR);
> > 
> > 	return !!enable ^ !(lpcr & SNVS_LPCR_SRTC_ENV);
> > }
> > [...]
> > 	while (1) {
> > 		if (svns_rtc_enable_done(enable, data->ioaddr))
> > 			break;
> > 
> > 		if (time_after(jiffies, timeout)) {
> > 			if (!svns_rtc_enable_done(enable, data->ioaddr))
> > 				return -ETIMEDOUT;
> > 		}
> > 	}
> > 
> I'm fine with this solution.  Can you send a formal patch for this?
> Then we will have two incremental patches (I already sent the fixed
> times loop one) for Andrew to choose one.
> 
What should I base this patch on?


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________