[PATCH 13/14] arm: at91: dt: at91sam9 add nand pinctrl support

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Thu Aug 16 13:38:44 EDT 2012


On 17:19 Thu 16 Aug     , Richard Genoud wrote:
> 2012/8/15 Linus Walleij <linus.walleij at linaro.org>:
> > On Fri, Aug 10, 2012 at 3:02 PM, Jean-Christophe PLAGNIOL-VILLARD
> > <plagnioj at jcrosoft.com> wrote:
> >
> >> Cc: Linus Walleij <linus.walleij at linaro.org>
> >> Cc: Nicolas Ferre <nicolas.ferre at atmel.com>
> >> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > (...)
> >> +                               nand {
> >> +                                       pinctrl_nand: nand-0 {
> >> +                                               atmel,pins =
> >> +                                                       <2 13 0x0 0x1   /* PC13 gpio RDY pin pull_up */
> >> +                                                        2 14 0x0 0x1>; /* PC14 gpio enable pin pull_up */
> >> +                                       };
> >> +                               };
> >
> > Again magic hex I don't understand so skipping this patch -> Nicolas.
> 
> Maybe it will be more readable if we use something like :
> atmel,pull-up;
> atmel,multidrive;
> atmel,mux="GPIO"
> atmel,mux="A"
> ...
> just my 2 cents...
no too much data and too much node as you will need a node per pin which we
tyr to avoid

Best Regards,
J.



More information about the linux-arm-kernel mailing list