[PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb

[Stephen Warren]

On 08/08/2012 01:37 PM, Tony Prisk wrote:
>> On 08/07/2012 07:39 PM, Tony Prisk wrote:
>>> Update vt8500-fb, wm8505-fb and wmt-ge-rops to support device
>>> tree bindings.

>>> diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
> 
>>> +     np = of_find_node_by_name(NULL, "display");
>>> +     if (!np) {
>>> +             pr_err("%s: No display description in Device Tree\n", __func__);
>>> +             ret = -EINVAL;
>>> +             goto failed_free_res;
>>> +     }
> 
>> I believe that using hard-coded node names is frowned upon. Better would
>> be to put a phandle into the display controller's node that points at
>> the node representing the display, e.g.:
> 
> Will do.

I don't think this change made it into v2?