[PATCH v2 1/4] dmaengine: mmp-pdma support

zhangfei gao zhangfei.gao at gmail.com
Tue Aug 14 00:02:32 EDT 2012


>
>> +Required properties:
>> +- compatible: Should be "marvell,pdma-1.0"
>> +- reg: Should contain DMA registers location and length.
>> +- interrupts: Either contain all of the per-channel DMA interrupts
>> +               or one irq for pdma device
>> +- dma-channels: Number of DMA channels supported by the controller.
>
> I think the last one should be "#dma-channels", not "dma-channels", since it's
> counting the channels. I think we use the "#" version in the preliminary binding
> for the generic dma channel assignment in DT.
>
>         Arnd
>

Thanks Arnd for careful review, will update with "#dma-channels" in v3.

> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



More information about the linux-arm-kernel mailing list