[PATCH 1/6] ARM: dove: unify clock setup

Sebastian Hesselbarth sebastian.hesselbarth at gmail.com
Sat Aug 11 05:38:59 EDT 2012


On 08/11/2012 11:12 AM, Andrew Lunn wrote:
>> +	/* Ensure tclk is always clocked */
>> +	clk_prepare_enable(tclk);
>>   }
>
> "ticking" would be better than clocked.
>
> Since this is a root fixed clock, is it necessary to prepare_enable()
> it? I think prepare and enable become NOPs in this situation.

Hi Andrew,

yes you are right, it is useless to prepare or enable a fixed rate clk.
I cannot be gated anyway. I'll update the patch and resend soon.

Sebastian




More information about the linux-arm-kernel mailing list