[PATCH 10/10] leds: renesas: fix error handling
arnd at arndb.de
Thu Aug 9 03:34:03 EDT 2012
On Thursday 09 August 2012, Bryan Wu wrote:
> On Thu, Aug 9, 2012 at 5:27 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> > bfe4c041 "leds: convert Renesas TPU LED driver to devm_kzalloc() and
> > cleanup error exit path" introduced a possible case in which r_tpu_probe
> > calls iounmap on a wild pointer. This changes the one case that was
> > missed in the same way as the other error paths.
> > Without this patch, building kota2_defconfig results in:
> > drivers/leds/leds-renesas-tpu.c: In function 'r_tpu_probe':
> > drivers/leds/leds-renesas-tpu.c:246:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
> > drivers/leds/leds-renesas-tpu.c:308:17: warning: 'p' may be used uninitialized in this function [-Wuninitialized]
> Thanks, Arnd. If you don't mind, I will apply this fixing through my led tree.
Ok, excellent. One less patch for me to worry about. Dropped from my tree now.
More information about the linux-arm-kernel