[PATCH] pinctrl: pinctrl-imx: add imx35 pinctrl driver

[Uwe Kleine-König]

Hi,

On Tue, Aug 07, 2012 at 04:04:01PM +0800, Dong Aisheng wrote:
> Some minor format comment.
> On 2 August 2012 23:39, Uwe Kleine-König <u.kleine-koenig at pengutronix.de> wrote:
> ........
> > +Required properties:
> > +- compatible: "fsl,imx35-iomuxc"
> > +- fsl,pins: two integers array, represents a group of pins mux and config
> > +  setting. The format is fsl,pins = <PIN_FUNC_ID CONFIG>, PIN_FUNC_ID is a
> > +  pin working on a specific function, CONFIG is the pad setting value like
> > +  pull-up for this pin. Please refer to imx53 datasheet for the valid pad
> s/imx53/imx35
obviously.

> > +See below for available PIN_FUNC_ID for imx35:
> > +# grep '   IMX_PIN_REG' drivers/pinctrl/pinctrl-imx35.c | awk '{ print NR-1 " " $8 }'
> > +0 MX35_PAD_CAPTURE__GPT_CAPIN1
> > +1 MX35_PAD_CAPTURE__GPT_CMPOUT2
> I'm not sure if you can use the format as exist IMX PIN_FUNC_ID tables as:
> MX35_PAD_CAPTURE__GPT_CAPIN1        0
> MX35_PAD_CAPTURE__GPT_CMPOUT2    1
I choosed to switch the order here to have a more column like format.
the length of the numbers is more uniform. I can switch if you want.

> Maybe the difficulty is the command (i did not know how to do it before),
> If you know, we can do like that.
> Anyway, it's not a big issue and does not block an ack.
> 
> > +enum imx35_pads {
> > +       /* sed -r -n 's@^#define MX35_PAD_([0-9A-Z_]*)__([0-9A-Z_]*)\s+IOMUX_PAD\(\s*([0-9a-fx]*),\s+([0-9a-fx]*),\s+([0-9a-fx]*),\s+([0-9a-fx]*),\s+([0-9]*),\s*NO_PAD_CTRL\)@\tMX35_PAD_\1, at p' arch/arm/plat-mxc/include/mach/iomux-mx35.h | uniq */
> > +       MX35_PAD_CAPTURE,
> > +       MX35_PAD_COMPARE,
> > +       MX35_PAD_WDOG_RST,
> > +       MX35_PAD_GPIO1_0,
> > +       MX35_PAD_GPIO1_1,
> > +       MX35_PAD_GPIO2_0,
> > +       MX35_PAD_GPIO3_0,
> Can we use the format as exist one?
> enum imx53_pads {
>         MX53_PAD_GPIO_19 = 1,
>         MX53_PAD_KEY_COL0 = 2,
>         MX53_PAD_KEY_ROW0 = 3,
>         MX53_PAD_KEY_COL1 = 4,
> .......
> }
> Then people can easy know its pin id.
> I'm wondering there may be still some debug info are using pin id
> then the above format helps.
I didn't see output referring to pin ids (which doesn't mean it doesn't
exist of course). I don't care much and wondered why you started at 1
and not 0. All it all it was just lazyness on my side not to add the
numers.
 
> > +module_exit(imx35_pinctrl_exit);
> > +MODULE_AUTHOR("Dong Aisheng <dong.aisheng at linaro.org>");
> Not your name?
No, I only did

	cp drivers/pinctrl/pinctrl-imx{51,35}.c

and fixed the tables and names for i.MX35. It's OK for me when you get
the blame. :-)

> Otherwise,
> you can add my ACK.
Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |