[PATCH 6/6] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots

Lee Jones lee.jones at linaro.org
Mon Aug 6 13:22:05 EDT 2012


On Mon, Aug 06, 2012 at 05:00:39PM +0100, Mark Brown wrote:
> On Mon, Aug 06, 2012 at 11:46:42AM +0100, Lee Jones wrote:
> > If we're booting with Device Tree enabled, we want the IRQ numbers to
> > be taken and translated from the Device Tree binary. If not, they
> > should be taken from the resource allocation defined in the AB8500 MFD
> > core driver.
> 
> >  	ponkey->ab8500 = ab8500;
> > -	ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
> > -	ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);
> > +
> > +	ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : irq_dbf;
> > +	ponkey->irq_dbr = (np) ? ab8500_irq_get_virq(ab8500, irq_dbr) : irq_dbr;
> 
> Shouldn't the irq domain be coping with this?  It seems like a massive
> failure to have to do this in every single user, the irq domain should
> be able to encapsulate all this stuff.

Already in hand.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog



More information about the linux-arm-kernel mailing list