[PATCH] i2c: mxs: disable QUEUE when sending is done
Marek Vasut
marex at denx.de
Sun Apr 29 05:11:13 EDT 2012
Dear Wolfram Sang,
> > > > I am wondering if we should only set QUEUE_RUN bit here.
> > >
> > > I didn't check the manual, but I guess writing to MXS_I2C_QUEUECTRL_CLR
> > > just clears the QUEUE_RUN bit and nothing else?!
> >
> > I think the RUN bit will be cleared by the controller anyway, so this
> > patch is pointless.
>
> How do you get this idea? Given 27.3.2 and our experiences, I'd be very
> surprised. Try putting the system under heavy load without this patch
> and you'll see that FIFOs might be sent half filled when interrupted
> while filling.
All right, I won't argue here ;-)
Best regards,
Marek Vasut
More information about the linux-arm-kernel
mailing list