[PATCH] i2c: mxs: disable QUEUE when sending is done

Wolfram Sang w.sang at pengutronix.de
Sun Apr 29 04:43:24 EDT 2012


> > > I am wondering if we should only set QUEUE_RUN bit here.
> > 
> > I didn't check the manual, but I guess writing to MXS_I2C_QUEUECTRL_CLR
> > just clears the QUEUE_RUN bit and nothing else?!
> 
> I think the RUN bit will be cleared by the controller anyway, so this patch is 
> pointless.

How do you get this idea? Given 27.3.2 and our experiences, I'd be very
surprised. Try putting the system under heavy load without this patch
and you'll see that FIFOs might be sent half filled when interrupted
while filling.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120429/67ca761f/attachment.sig>


More information about the linux-arm-kernel mailing list