[PATCH 3/9] SPEAr13xx: Add common clock framework support

Viresh Kumar viresh.kumar at st.com
Mon Apr 23 23:57:45 EDT 2012


On 4/24/2012 3:13 AM, Turquette, Mike wrote:
>> > +void __init spear1310_clk_init(void)
>> > +{
>> > +       struct clk *clk, *clk1;
>> > +
>> > +       clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, CLK_IS_ROOT, 0);
>> > +       clk_register_clkdev(clk, "apb_pclk", NULL);
> There is no exception handling at all in this function.  Do you just
> expect to fail at some later point?

This is what Russell suggested in his clkdev patch. We don't have to check clk *
returned from clk_register_*(). This will be done in clk_register_clkdev(), clk
lookup wouldn't be registered for failing clocks.

-- 
viresh



More information about the linux-arm-kernel mailing list