[PATCH 3/9] SPEAr13xx: Add common clock framework support

[Turquette, Mike]

On Fri, Apr 20, 2012 at 10:22 AM, Viresh Kumar <viresh.linux at gmail.com> wrote:
> This patch adds SPEAr1310 and SPEAr1340's clock framework support. It is based
> on earlier support for SPEAr3xx family.
>
> Signed-off-by: Viresh Kumar <viresh.kumar at st.com>
> Cc: Mike Turquette <mturquette at ti.com>
> ---
> Mike,
>
> This would be required to go through Arnd's tree. So would be great if i can
> have your comments/Ack here.

Most of this patch looks good to me accept for the two items below:

...

> +void __init spear1310_clk_init(void)
> +{
> +       struct clk *clk, *clk1;
> +
> +       clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, CLK_IS_ROOT, 0);
> +       clk_register_clkdev(clk, "apb_pclk", NULL);

There is no exception handling at all in this function.  Do you just
expect to fail at some later point?

...

> +void __init spear1340_clk_init(void)
> +{
> +       struct clk *clk, *clk1;
> +
> +       clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, CLK_IS_ROOT, 0);
> +       clk_register_clkdev(clk, "apb_pclk", NULL);

Ditto.

Regards,
Mike