[PATCH 2/2] ARM: Switch to using CLKDEV_INIT macro for creating clk_lookup instance

[H Hartley Sweeten]

On Friday, September 30, 2011 5:35 AM, Ryan Mallon wrote:
> On 30/09/11 21:11, Padmavathi Venna wrote:
>> Replace platform specific macros that creates struct clk_lookup
>> instance with the new common CLKDEV_INIT macro
>>
>> Suggested by: Russell King <rmk+kernel at arm.linux.org.uk>
>> Signed-off-by: Padmavathi Venna <padma.v at samsung.com>
>> ---

[...]

>>  static struct clk_lookup cdce_clks[] = {
>> -	CLK(NULL, "xin", &cdce_clk_in),
>> -	CLK(NULL, NULL, NULL),
>> +	CLKDEV_INIT(NULL, "xin", cdce_clk_in)
>> +	{.dev_id = NULL, .con_id = NULL, .clk = NULL,},
>
> Why not CLKDEV_INIT(NULL, NULL, NULL)? Or create another macro
> CLKDEV_NULL (or similar) for the last entry in the list rather than
> duplicating this everywhere.

The CLKDEV_INIT macro does this with the third parameter:

	.clk = &c,

I'm not sure &NULL is valid.

Is the sentinel entry actually needed?  ep93xx does not have one.

Regards,
Hartley