[PATCH 1/5] ARM: pxa: remove redundant macro on GPIO

Haojian Zhuang haojian.zhuang at gmail.com
Thu Sep 29 23:30:08 EDT 2011


2011/9/30 Eric Miao <eric.y.miao at gmail.com>:
> 2011/9/30 Michał Mirosław <mirqus at gmail.com>:
>> 2011/9/29 Haojian Zhuang <haojian.zhuang at marvell.com>:
>> [...]
>>>        if (type & IRQ_TYPE_EDGE_RISING)
>>> -               GRER0 |= GPIO_bit(gpio);
>>> +               GRER(gpio) |= GPIO_bit(gpio);
>> [...]
>>
>> This looks wrong. There are more occurrences like this. Can you
>> explain if this is correct?
>
> This is actually correct. In GRER(x) - x designates the GPIO instead
> of the subindex n in GRERn.
>
> The rest of the direct references GPxRn have been mostly removed
> during the last several rounds of cleanup.
>
> Haojian,
>
> Please use
>
> 'git grep GP.R[0-9]'
>
> and
>
> 'git grep GR.R[0-9]'
>
> to rule out the rest references. I'm good with the patch, just to
> make sure there is no more such reference.
>
There's no reference to GP.R and GR.R registers except for comment.



More information about the linux-arm-kernel mailing list