[PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

Linus Walleij linus.walleij at linaro.org
Wed Sep 28 07:58:50 EDT 2011


On Wed, Sep 28, 2011 at 2:15 AM, Stephen Warren <swarren at nvidia.com> wrote:

> But can't debugfs just get its information from the device name field in
> the mapping table? I'm not sure why the need to use that information for
> debugfs prevents the having entries with both the hog flag set and a
> device name set?

That feels unsafe - then you have some string claiming to represent the
device for that pinmux, but the system has not matched that string
against dev_name() for any real device, so it could be a lie, any string
like "foo" would do.

What I do now for U300 is complete resolution by matching dev_name
in the mapping to dev_name(device) on the struct device * actually
instantiated, which means you're 100% sure it is really mapped
to that very device.

I like this since it's much more stringent...

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list