[PATCH 3/3] mmc: mmci: Change vdd_handler to a generic ios_handler

Linus Walleij linus.walleij at linaro.org
Wed Sep 28 01:34:05 EDT 2011

On Tue, Sep 27, 2011 at 1:42 PM, Ulf Hansson <ulf.hansson at stericsson.com> wrote:

> The purpose of the vdd_handler does not make sense. We remove it
> and use a generic approach instead. A new ios_handler is added, the
> purpose of which e.g. can be to control GPIO pins to a levelshifter.
> Previously the vdd_handler was also used for making additional
> changes to the power register bits. This option is superfluous and is
> therefore removed.
> Adaptaptions from the old vdd_handler to the new ios_handler is done for
> mach-ux500 board, which was the only one using the vdd_handler.

I've tried to undestand (by reading the data sheets I have) what the
purpose of the original 4 power bits handled by the mechanism that
nobody really use is, and I'm still lost.

I'm guessing it was some feature intended to control e.g. a
regulator of some kind by routing them off-chip (since mixed-signal
chips rarely have MMC controllers inside...) and most designers
already have their own regulator designs so it made no sense
for anyone to actually implement it that way.

If some vendor would actually start using these bits for the
intended purpose I guess we could adapt. (The pirate driver
msm_sdcc.c does not seem to use these bits either BTW.)

Acked-by: Linus Walleij <linus.walleij at linaro.org>

Linus Walleij

More information about the linux-arm-kernel mailing list