[PATCH] S3C2443: Fix bit-reset in setrate of clk_armdiv

Kukjin Kim kgene.kim at samsung.com
Mon Sep 26 00:26:37 EDT 2011


Heiko Stübner wrote:
> 
> The changed statement should set the old armdiv bits to 0
> and not everything else, before setting the new value.
> 
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> ---
>  arch/arm/mach-s3c2443/clock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
> index 966bde5..27549c4 100644
> --- a/arch/arm/mach-s3c2443/clock.c
> +++ b/arch/arm/mach-s3c2443/clock.c
> @@ -124,7 +124,7 @@ static int s3c2443_armclk_setrate(struct clk *clk,
unsigned
> long rate)
>  		unsigned long clkcon0;
> 
>  		clkcon0 = __raw_readl(S3C2443_CLKDIV0);
> -		clkcon0 &= S3C2443_CLKDIV0_ARMDIV_MASK;
> +		clkcon0 &= ~S3C2443_CLKDIV0_ARMDIV_MASK;
>  		clkcon0 |= val << S3C2443_CLKDIV0_ARMDIV_SHIFT;
>  		__raw_writel(clkcon0, S3C2443_CLKDIV0);
>  	}
> --
> 1.7.2.3

Hi Heiko,

Yes, you're right.
Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list