[PATCH 0/8] OMAP3/4: Misc fixes and clean-up
santosh.shilimkar at ti.com
Sat Sep 24 03:46:35 EDT 2011
On Saturday 24 September 2011 01:06 PM, Paul Walmsley wrote:
> On Sat, 24 Sep 2011, Santosh Shilimkar wrote:
>> On Saturday 24 September 2011 12:01 PM, Paul Walmsley wrote:
>>> Hi Santosh
>>> On Sat, 24 Sep 2011, Santosh Shilimkar wrote:
>>>> On Thursday 08 September 2011 10:51 AM, Santosh Shilimkar wrote:
>>>> I need your ack on below two patches so that I can re-base them and
>>>> send a pull request to Tony.
>>>> OMAP4: clock: Add CPU local timer clock node.
>>>> OMAP: Fix sparse warnings in l3 error handler.
>>> Are you targeting these for 3.1-rc ?
>> Nope. It's for 3.2 merge window.
>> As such, the series doesn't have any major regression
>> fixes which should make it before 3.2
> In that case, patches 1 and 7 should go in through me. The rest should go
> via Tony. So you can just drop 1 and 7 from your branch, I'll pull those
> off the list.
> Some comments though: Looks like you need to repost patch 1 due to
> comments from Benoît? Also, have the autogeneration scripts been updated
> for patch 7?
Ok. Will post updated patch1.
For the patch 7, I will align with Benoit on the autogen script. It has
some differences with mainline OMAP4 clock data file.
> As far as patch 5 goes, you don't need my ack on that one, since I'm not
> the maintainer or original author of that code. But feel free to add a
> Reviewed-by:. I also tested the two L3 files with sparse and they are
> clean now. Thanks very much for taking the initiative on this; I
> personally appreciate it quite a bit, and I think having clean code
> increases our credibility with upstream maintainers.
Actually I wanted you to have a look to ensure that we addressed the
all sparce warnings. Will add your reviewed by on that patch.
Couldn't agree more on the clean code remark.
More information about the linux-arm-kernel