[PATCH v3 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option
Grant Likely
grant.likely at secretlab.ca
Thu Sep 22 13:35:07 EDT 2011
On Mon, Sep 19, 2011 at 03:49:12PM +0530, Thomas Abraham wrote:
> For platforms using device tree, the static keypad device instances
> are not required and SAMSUNG_DEV_KEYPAD is not selected. Since,
> samsung keypad driver has dependency on SAMSUNG_DEV_KEYPAD config
> option, the driver is left out of the compilation for dt enabled
> platforms.
>
> An additional config option 'HAVE_SAMSUNG_KEYPAD' is added
> which the device tree based platforms can select. This config
> option is added as an alternative dependency for keypad driver.
>
> Signed-off-by: Thomas Abraham <thomas.abraham at linaro.org>
> ---
> drivers/input/keyboard/Kconfig | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index b4dee9d..7c322a3 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -423,9 +423,16 @@ config KEYBOARD_PMIC8XXX
> To compile this driver as a module, choose M here: the module will
> be called pmic8xxx-keypad.
>
> +config HAVE_SAMSUNG_KEYPAD
> + bool
> + help
> + This will include Samsung Keypad controller driver support. If you
> + want to include Samsung Keypad support for any machine, kindly
> + select this in the respective mach-xxxx/Kconfig file.
> +
> config KEYBOARD_SAMSUNG
> tristate "Samsung keypad support"
> - depends on SAMSUNG_DEV_KEYPAD
> + depends on SAMSUNG_DEV_KEYPAD || HAVE_SAMSUNG_KEYPAD
It would be better to modify SAMSUNG_DEV_KEYPAD to select
HAVE_SAMSUNG_KEYPAD and then make KEYBOARD_SAMSUNG only depend on
HAVE_SAMSUNG_KEYPAD instead of both.
g.
More information about the linux-arm-kernel
mailing list