[PATCH V2 1/6] spi/spi-pl022: Resolve formatting issues

Grant Likely grant.likely at secretlab.ca
Tue Sep 20 13:17:06 EDT 2011


On Wed, Aug 10, 2011 at 02:20:54PM +0530, Viresh Kumar wrote:
> There were few formatting related issues in code. This patch fixes them.
> Fixes include:
> - Remove extra blank lines
> - align code to 80 cols
> - combine several lines to one line
> - Replace multiple spaces with tabs
> - Remove spaces before labels
> 
> Signed-off-by: Viresh Kumar <viresh.kumar at st.com>
> Tested-by: Linus Walleij <linus.walleij at linaro.org>
> @@ -2243,23 +2233,23 @@ pl022_probe(struct amba_device *adev, const struct amba_id *id)
>  	amba_vcore_disable(adev);
>  	return 0;
>  
> - err_spi_register:
> - err_start_queue:
> - err_init_queue:
> +err_spi_register:
> +err_start_queue:
> +err_init_queue:
>  	destroy_queue(pl022);
>  	pl022_dma_remove(pl022);
>  	free_irq(adev->irq[0], pl022);
>  	pm_runtime_disable(&adev->dev);
> - err_no_irq:
> +err_no_irq:
>  	clk_put(pl022->clk);
> - err_no_clk:
> +err_no_clk:
>  	iounmap(pl022->virtbase);
> - err_no_ioremap:
> +err_no_ioremap:
>  	amba_release_regions(adev);
> - err_no_ioregion:
> +err_no_ioregion:
>  	spi_master_put(master);
> - err_no_master:
> - err_no_pdata:
> +err_no_master:
> +err_no_pdata:

These label indentations are actually on purpose.  I'll apply the rest
of the patch, but I'm going to remove this hunk.  Indenting error
labels by 1 space makes 'diff' show the function name instead of the
label in the context line.

g.




More information about the linux-arm-kernel mailing list