[PATCH 3/5] of/irq: introduce of_irq_init
Arnd Bergmann
arnd at arndb.de
Thu Sep 15 06:41:32 EDT 2011
On Wednesday 14 September 2011, Rob Herring wrote:
> From: Rob Herring <rob.herring at calxeda.com>
>
> of_irq_init will scan the devicetree for matching interrupt controller
> nodes. Then it calls an initialization function for each found controller
> in the proper order with parent nodes initialized before child nodes.
>
> Based on initial pseudo code from Grant Likely.
>
> Signed-off-by: Rob Herring <rob.herring at calxeda.com>
> Cc: Grant Likely <grant.likely at secretlab.ca>
Looks good to me,
Acked-by: Arnd Bergmann <arnd at arndb.de>
> +
> +struct intc_desc {
> + struct list_head list;
> + struct device_node *dev;
> + struct device_node *parent;
> +};
One tiny comment: how about naming the parent 'interrupt_parent'? While
reading through the code, I was confused for a short time until I figured
out what this is about.
Arnd
More information about the linux-arm-kernel
mailing list