[PATCH] ARM: mach-mxs/mx28evk: Only register devices if their GPIO requests succeeded

Fabio Estevam festevam at gmail.com
Tue Sep 13 23:12:40 EDT 2011


On Wed, Sep 14, 2011 at 12:18 AM, Shawn Guo <shawn.guo at freescale.com> wrote:
> On Tue, Sep 13, 2011 at 05:25:19PM -0300, Fabio Estevam wrote:
>> Currently framebuffer and MMC devices are registered even if their associated
>> GPIO pins fail to be requested.
>>
>> Change the logic so that the registration of such devices only occurs if their
>> GPIO requests succeeded.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>> ---
> So the question is whether the gpio request failure is a show-stopper
> failure for framebuffer and mmc.

If the GPIO that controls LCD enable or backlight enable failed it is
not very useful to register the framebuffer, do you agree?

Same for MMC.

You did the same logic for the CAN bus, so I extended it for the
framebuffer and MMC.

Regards,

Fabio Estevam



More information about the linux-arm-kernel mailing list