[PATCH] Add platform driver support to the CS890x driver

[Uwe Kleine-König]

Hello,

On Tue, Sep 13, 2011 at 09:44:24AM +0200, Sascha Hauer wrote:
> On Wed, Sep 07, 2011 at 02:50:47PM +0200, Uwe Kleine-König wrote:
> > > +		printk(KERN_WARNING
> > > +		       DRV_NAME
> > > +		       ": memory and/or interrupt resource missing.\n");
> > I'd prefer you do:
> > 
> > 	#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > 
> > at the top of the driver and then just use:
> > 
> > 	pr_warning("memory and/or interrupt resource missing\m");
> 
> Why not use dev_warn??
Yeah, that works, too.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |