[PATCH] Add platform driver support to the CS890x driver

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Sep 12 08:30:23 EDT 2011


Hello Jaccon,

On Mon, Sep 12, 2011 at 12:52:52PM +0200, Jaccon Bastiaansen wrote:
> 2011/9/11 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> >             On some machines (e.g arm/imx/mx31ads) some magic constants
> > are defined somewhere in arch/ to fill in netcard_portlist and
> > cs8900_irq_map. On these machines the cs8900 driver does drive some
> > hardware, but not via the platform bus. This is what i want to have
> > changed.
> >
> 
> Ok, so you would like to see the #ifdefs for the IXDP2351, IXDP2X01,
> QQ2440 and MX31ADS in the cs890x driver replaced by platform_device
> definitions in the platform specific code of those platforms (in the
> same way as I have done for the i.MX21ADS platform)? Is this correct?
More or less, yes. I would have started to keep the change local to
the cs8900 driver, but moving the devices to arch is the final goal.

The upside of first reworking the driver and only then move the devices
out is that it might be better/easier to bisect and review.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list